Added ABC Analysis Setup to Power BI Reports BC app by tuan-nguyen-fenwick · Pull Request #5869 · microsoft/BCApps

tuan-nguyen-fenwick · 2025-12-17T00:57:27Z

Prerequisite

Requires PR completion: https://github.com/microsoft/BusinessCentralApps/pull/1757

Change summary

New ABC Analysis page for Inventory Power BI Report:

Added ABC Analysis Setup table & page
Added ABC Analysis API query
Added embedded page
Handled ABC Analysis Setup initialization during app installation and upgrade

Fixes AB#606229

tuan-nguyen-fenwick · 2025-12-17T00:57:51Z

@mynjj Can you review this PR for Power BI Reports BC app please?

github-actions · 2025-12-17T00:58:02Z

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

src/Apps/W1/PowerBIReports/App/Inventory/Pages/ABCAnalysisSetup.Page.al

mynjj · 2025-12-17T16:51:51Z

src/Apps/W1/PowerBIReports/App/Core/Codeunits/PowerBIUpgrade.Codeunit.al

        UpgradeTag.SetUpgradeTag(CloseIncomeSourceCodeUpgradeTag());
    end;

+    local procedure InitializeABCAnalysisSetupUpgrade()


From what I see that the initialization does, we could do this on the fly instead of at upgrade. Let's do that, let's say when opening the main setup page, and if the setup is needed and it's not there, return default values.

+1 for this approach.

@tuan-nguyen-fenwick , what do you think about this suggestion? to initialize on the fly instead of needing to add upgrade code

src/Apps/W1/PowerBIReports/App/Inventory/Embedded/Inventory/ABCAnalysis.Page.al

src/Apps/W1/PowerBIReports/App/Inventory/Pages/ABCAnalysisSetup.Page.al

mynjj · 2025-12-17T16:55:33Z

src/Apps/W1/PowerBIReports/App/Inventory/Embedded/Inventory/ABCAnalysis.Page.al

+    var
+        SetupHelper: Codeunit "Power BI Report Setup";
+        ReportId: Guid;
+        ReportPageLbl: Label 'a476d6afc8d5d544193b', Locked = true;


this report id doesn't seem to be in yet, should we include it in this PR? I'm also fine if you want to keep it in a separate PR

src/Apps/W1/PowerBIReports/App/Inventory/Tables/ABCAnalysisSetup.Table.al

src/Apps/W1/PowerBIReports/App/Inventory/Pages/ABCAnalysisSetup.Page.al

src/Apps/W1/PowerBIReports/App/Inventory/Tables/ABCAnalysisSetup.Table.al

mynjj · 2026-01-19T12:56:38Z

src/Apps/W1/PowerBIReports/App/Core/Codeunits/PowerBIUpgrade.Codeunit.al

        UpgradeTag.SetUpgradeTag(CloseIncomeSourceCodeUpgradeTag());
    end;

+    local procedure InitializeABCAnalysisSetupUpgrade()


@tuan-nguyen-fenwick , what do you think about this suggestion? to initialize on the fly instead of needing to add upgrade code

mynjj · 2026-01-19T12:57:58Z

src/Apps/W1/PowerBIReports/App/Core/PermissionSets/PowerBIReportAdmin.PermissionSet.al

        tabledata "PowerBI Reports Setup" = RIMD,
        tabledata "Working Day" = RIMD,
-        tabledata "Account Category" = RM;
+        tabledata "Account Category" = RMID,


why did we add the "ID" to account category for this functionality?

mynjj · 2026-01-19T12:59:13Z

src/Apps/W1/PowerBIReports/App/Core/PermissionSets/PowerBIReportAdmin.PermissionSet.al

        tabledata "Working Day" = RIMD,
-        tabledata "Account Category" = RM;
+        tabledata "Account Category" = RMID,
+        tabledata "PowerBI ABC Analysis Setup" = RMID;


very minor 😅 : it's usually RIMD (in that order)

src/Apps/W1/PowerBIReports/App/Inventory/Embedded/Inventory/ABCAnalysis.Page.al

mynjj · 2026-01-19T13:02:13Z

src/Apps/W1/PowerBIReports/App/Inventory/Pages/PowerBIABCAnalysisSetup.Page.al

+// ------------------------------------------------------------------------------------------------
+namespace Microsoft.Inventory.PowerBIReports;
+
+page 36982 "PowerBI ABC Analysis Setup"


same here, you were missing to rename the file

mynjj · 2026-01-19T13:05:18Z

src/Apps/W1/PowerBIReports/App/Inventory/Tables/PowerBIABCAnalysisSetup.Table.al

+// ------------------------------------------------------------------------------------------------
+namespace Microsoft.Inventory.PowerBIReports;
+
+table 36956 "PowerBI ABC Analysis Setup"


missing to rename the file

PredragMaricic · 2026-01-09T17:34:56Z

src/Apps/W1/PowerBIReports/App/Core/Codeunits/PowerBIUpgrade.Codeunit.al


+    local procedure InitializeABCAnalysisSetupUpgradeTag(): Code[250]
+    begin
+        exit('MS-TEMP-POWERBI-ABC-ANALYSIS-SETUP-20251216'); //TODO: To be confirmed with Microsoft team.


Ok, so you need workitem No. It is 606229. The code could be like this:

exit('MS-606229-PowerBIABCAnalysisSetup-20251216')

PredragMaricic · 2026-01-09T18:36:20Z

src/Apps/W1/PowerBIReports/App/Core/Codeunits/PowerBIUpgrade.Codeunit.al

        UpgradeTag.SetUpgradeTag(CloseIncomeSourceCodeUpgradeTag());
    end;

+    local procedure InitializeABCAnalysisSetupUpgrade()


+1 for this approach.

PredragMaricic

Please fix comments above

tuan-nguyen-fenwick · 2026-01-27T23:57:51Z

Please fix comments above

@PredragMaricic Thank you, I've updated the upgrade tag. All other comments can be resolved.

tuan-nguyen-fenwick · 2026-02-02T06:08:39Z

@PredragMaricic
FYI, I have adjusted changes on this PR after migrating ABC Analysis Setup page & table to Base App in #1757

Tuan Nguyen added 5 commits December 17, 2025 11:54

Added ABC Analysis Setup page & table

f6827a2

Added ABC Analysis Setup query

9a6c487

Added ABC Analysis Setup during app installation & upgrade

fd75492

Updated ABC Analysis Setup objects to permission sets

50ba99f

Added ABC Analysis embedded page

007c9b4

tuan-nguyen-fenwick requested a review from a team as a code owner December 17, 2025 00:57

github-actions bot added AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork labels Dec 17, 2025

KennieNP reviewed Dec 17, 2025

View reviewed changes

src/Apps/W1/PowerBIReports/App/Inventory/Pages/ABCAnalysisSetup.Page.al Outdated Show resolved Hide resolved

JesperSchulz added the Finance GitHub request for Finance area label Dec 17, 2025

mynjj requested changes Dec 17, 2025

View reviewed changes

mynjj self-assigned this Dec 23, 2025

Tuan Nguyen added 2 commits January 2, 2026 15:09

Renamed & improved ABC Analysis Setup objects

d0d713a

Renamed PowerBI ABC Analysis embedded page

b6bc6c7

matilda-teitzel mentioned this pull request Jan 8, 2026

Power BI Inventory App v28: ABC Analysis #6075

Open

tuan-nguyen-fenwick requested a review from mynjj January 15, 2026 00:04

mynjj requested changes Jan 19, 2026

View reviewed changes

Tuan Nguyen added 3 commits January 21, 2026 14:13

Renamed files

311dfec

Reordered RIMD permissions

e9e900b

Reverted Account Category permissions

821bb6c

tuan-nguyen-fenwick requested a review from mynjj January 21, 2026 05:24

PredragMaricic reviewed Jan 27, 2026

View reviewed changes

PredragMaricic requested changes Jan 27, 2026

View reviewed changes

Updated upgrade tag for ABC Analysis Setup

f8c62c3

Tuan Nguyen added 3 commits February 2, 2026 16:57

Updated dataitem to reference ABC Analysis Setup from Base App

b183688

Removed ABC Analysis Setup table & page (Migrated to Base App)

4edf426

Updated permission sets

450cf51

Tuan Nguyen added 6 commits February 2, 2026 17:00

Removed ABC Analysis Setup upgrade & initialization

52c1990

Removed ABC Analysis Setup action

81e6d95

Removed InitializeABCAnalysisSetupUpgradeTag function

882c436

Removed unused using

3c899f6

Removed using

279eb88

Cleaned up using

1d4fe34

tuan-nguyen-fenwick requested a review from PredragMaricic February 2, 2026 06:07

github-actions bot added the Linked Issue is linked to a Azure Boards work item label Feb 2, 2026

github-actions bot added this to the Version 28.0 milestone Feb 2, 2026

PredragMaricic approved these changes Feb 3, 2026

View reviewed changes

Conversation

tuan-nguyen-fenwick commented Dec 17, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Prerequisite

Change summary

Uh oh!

tuan-nguyen-fenwick commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PredragMaricic left a comment

Choose a reason for hiding this comment

Uh oh!

tuan-nguyen-fenwick commented Jan 27, 2026

Uh oh!

tuan-nguyen-fenwick commented Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tuan-nguyen-fenwick commented Dec 17, 2025 •

edited by github-actions bot

Loading